Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs and add requirements checks #109

Merged
merged 12 commits into from
Mar 1, 2022
Merged

Fix bugs and add requirements checks #109

merged 12 commits into from
Mar 1, 2022

Conversation

TimvdHeijden
Copy link
Contributor

@TimvdHeijden TimvdHeijden commented Feb 28, 2022 •
edited
Loading

Done in this PR:

  • Add requirements.txt vs. setup.cfg comparison
  • Add test with raising error when column names are not unique
  • Remove the previous test on uniqueness of columns, since it did not work

@TimvdHeijden
Copy link
Contributor Author

@erfannariman Test bij gebouwd en de oude check voor upsert herstelt.

@erfannariman
Copy link
Member

Looks good @TimvdHeijden thanks

@erfannariman erfannariman merged commit 01aa074 into development Mar 1, 2022
@erfannariman erfannariman deleted the fix-not-unique-cols-bug branch March 1, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erfannariman erfannariman erfannariman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimvdHeijden @erfannariman